[PATCH] D45389: [Power9]Legalize and emit code for converting (Un)Signed Word to Quad-Precision

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

Other than a couple of minor nits, LGTM.



================
Comment at: test/CodeGen/PowerPC/f128-conv.ll:167
+; CHECK-LABEL: swConv2qp_02
+; CHECK-NOT: ld
+; CHECK: lxsiwax [[REG:[0-9]+]], 0, 4
----------------
Is this supposed to be `CHECK-NOT: lwz`?


================
Comment at: test/CodeGen/PowerPC/f128-conv.ll:186
+; CHECK: ld [[REG]], .LC2 at toc@l([[REG]])
+; CHECK: lxsiwax [[REG0:[0-9]+]], 0, [[REG]]
+; CHECK-NEXT: xscvsdqp [[CONV:[0-9]+]], [[REG0]]
----------------
This seems weird. Where is the offset from the start of the array calculated?


https://reviews.llvm.org/D45389