[PATCH] D45420: [NFC] [LoopUtil] Moved RecurrenceDescriptor/LoopDescriptor from Transform/Utils/LoopUtils.* to Analysis tree

[Renato Golin via Phabricator via llvm-commits]

rengolin added reviewers: hfinkel, mkuper, chandlerc.
rengolin added a comment.

So, I never liked `LoopUtils` and I agree a lot of it should go to `Analysis` but having two copies of `LoopUtils` is bound to confuse people when including the headers.

Induction and reduction analysis is very core to the vectoriser, that's why it's always been there. I'd prefer a more specific approach like naming it `InductionAnalysis` or `RecurrenceAnalysis` and only moving those parts out to `Analysis`.

Being this a higher level change, I'd like more people to have a look at it. Adding them as reviewers.

cheers
--renato



================
Comment at: lib/Transforms/Scalar/LICM.cpp:46
 #include "llvm/Analysis/MemorySSA.h"
+#include "llvm/Analysis/MustExecute.h"
 #include "llvm/Analysis/OptimizationRemarkEmitter.h"
----------------
hsaito wrote:
> rengolin wrote:
> > Why these new includes?
> Moved #include from .h to .cpp. Header file doesn't really need to #include. it  Forward declaration of class names are enough.  Just followed "#include as little as possible" when I tried to figure out which #includes are actually needed.
Ah, makes sense, thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D45420