[llvm] r329895 - [llvm-mca] Removed unused argument from cycleEvent. NFC
Andrea Di Biagio via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 12 03:49:40 PDT 2018
Author: adibiagio
Date: Thu Apr 12 03:49:40 2018
New Revision: 329895
URL: http://llvm.org/viewvc/llvm-project?rev=329895&view=rev
Log:
[llvm-mca] Removed unused argument from cycleEvent. NFC
Modified:
llvm/trunk/tools/llvm-mca/Backend.cpp
llvm/trunk/tools/llvm-mca/Dispatch.h
llvm/trunk/tools/llvm-mca/DispatchStatistics.h
llvm/trunk/tools/llvm-mca/HWEventListener.h
llvm/trunk/tools/llvm-mca/RetireControlUnitStatistics.h
llvm/trunk/tools/llvm-mca/Scheduler.cpp
llvm/trunk/tools/llvm-mca/Scheduler.h
llvm/trunk/tools/llvm-mca/SchedulerStatistics.h
llvm/trunk/tools/llvm-mca/SummaryView.h
llvm/trunk/tools/llvm-mca/TimelineView.h
Modified: llvm/trunk/tools/llvm-mca/Backend.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/Backend.cpp?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/Backend.cpp (original)
+++ llvm/trunk/tools/llvm-mca/Backend.cpp Thu Apr 12 03:49:40 2018
@@ -52,10 +52,10 @@ void Backend::runCycle(unsigned Cycle) {
void Backend::notifyCycleBegin(unsigned Cycle) {
DEBUG(dbgs() << "[E] Cycle begin: " << Cycle << '\n');
for (HWEventListener *Listener : Listeners)
- Listener->onCycleBegin(Cycle);
+ Listener->onCycleBegin();
- DU->cycleEvent(Cycle);
- HWS->cycleEvent(Cycle);
+ DU->cycleEvent();
+ HWS->cycleEvent();
}
void Backend::notifyInstructionEvent(const HWInstructionEvent &Event) {
@@ -88,6 +88,6 @@ void Backend::notifyReleasedBuffers(Arra
void Backend::notifyCycleEnd(unsigned Cycle) {
DEBUG(dbgs() << "[E] Cycle end: " << Cycle << "\n\n");
for (HWEventListener *Listener : Listeners)
- Listener->onCycleEnd(Cycle);
+ Listener->onCycleEnd();
}
} // namespace mca.
Modified: llvm/trunk/tools/llvm-mca/Dispatch.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/Dispatch.h?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/Dispatch.h (original)
+++ llvm/trunk/tools/llvm-mca/Dispatch.h Thu Apr 12 03:49:40 2018
@@ -289,7 +289,7 @@ public:
return RAT->collectWrites(Vec, RegID);
}
- void cycleEvent(unsigned Cycle) {
+ void cycleEvent() {
RCU->cycleEvent();
AvailableEntries =
CarryOver >= DispatchWidth ? 0 : DispatchWidth - CarryOver;
Modified: llvm/trunk/tools/llvm-mca/DispatchStatistics.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/DispatchStatistics.h?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/DispatchStatistics.h (original)
+++ llvm/trunk/tools/llvm-mca/DispatchStatistics.h Thu Apr 12 03:49:40 2018
@@ -67,9 +67,9 @@ public:
void onInstructionEvent(const HWInstructionEvent &Event) override;
- void onCycleBegin(unsigned Cycle) override { NumCycles++; }
+ void onCycleBegin() override { NumCycles++; }
- void onCycleEnd(unsigned Cycle) override { updateHistograms(); }
+ void onCycleEnd() override { updateHistograms(); }
void onStallEvent(const HWStallEvent &Event) override;
Modified: llvm/trunk/tools/llvm-mca/HWEventListener.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/HWEventListener.h?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/HWEventListener.h (original)
+++ llvm/trunk/tools/llvm-mca/HWEventListener.h Thu Apr 12 03:49:40 2018
@@ -116,8 +116,8 @@ public:
class HWEventListener {
public:
// Generic events generated by the backend pipeline.
- virtual void onCycleBegin(unsigned Cycle) {}
- virtual void onCycleEnd(unsigned Cycle) {}
+ virtual void onCycleBegin() {}
+ virtual void onCycleEnd() {}
virtual void onInstructionEvent(const HWInstructionEvent &Event) {}
virtual void onStallEvent(const HWStallEvent &Event) {}
Modified: llvm/trunk/tools/llvm-mca/RetireControlUnitStatistics.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/RetireControlUnitStatistics.h?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/RetireControlUnitStatistics.h (original)
+++ llvm/trunk/tools/llvm-mca/RetireControlUnitStatistics.h Thu Apr 12 03:49:40 2018
@@ -50,9 +50,9 @@ public:
void onInstructionEvent(const HWInstructionEvent &Event) override;
- void onCycleBegin(unsigned Cycle) override { NumCycles++; }
+ void onCycleBegin() override { NumCycles++; }
- void onCycleEnd(unsigned Cycle) override { updateHistograms(); }
+ void onCycleEnd() override { updateHistograms(); }
void printView(llvm::raw_ostream &OS) const override;
};
Modified: llvm/trunk/tools/llvm-mca/Scheduler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/Scheduler.cpp?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/Scheduler.cpp (original)
+++ llvm/trunk/tools/llvm-mca/Scheduler.cpp Thu Apr 12 03:49:40 2018
@@ -284,7 +284,7 @@ void Scheduler::scheduleInstruction(unsi
ReadyQueue[Idx] = &MCIS;
}
-void Scheduler::cycleEvent(unsigned /* unused */) {
+void Scheduler::cycleEvent() {
SmallVector<ResourceRef, 8> ResourcesFreed;
Resources->cycleEvent(ResourcesFreed);
Modified: llvm/trunk/tools/llvm-mca/Scheduler.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/Scheduler.h?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/Scheduler.h (original)
+++ llvm/trunk/tools/llvm-mca/Scheduler.h Thu Apr 12 03:49:40 2018
@@ -464,7 +464,7 @@ public:
bool canBeDispatched(unsigned Idx, const InstrDesc &Desc) const;
void scheduleInstruction(unsigned Idx, Instruction &MCIS);
- void cycleEvent(unsigned Cycle);
+ void cycleEvent();
#ifndef NDEBUG
void dump() const;
Modified: llvm/trunk/tools/llvm-mca/SchedulerStatistics.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/SchedulerStatistics.h?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/SchedulerStatistics.h (original)
+++ llvm/trunk/tools/llvm-mca/SchedulerStatistics.h Thu Apr 12 03:49:40 2018
@@ -69,9 +69,9 @@ public:
void onInstructionEvent(const HWInstructionEvent &Event) override;
- void onCycleBegin(unsigned Cycle) override { NumCycles++; }
+ void onCycleBegin() override { NumCycles++; }
- void onCycleEnd(unsigned Cycle) override { updateHistograms(); }
+ void onCycleEnd() override { updateHistograms(); }
// Increases the number of used scheduler queue slots of every buffered
// resource in the Buffers set.
Modified: llvm/trunk/tools/llvm-mca/SummaryView.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/SummaryView.h?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/SummaryView.h (original)
+++ llvm/trunk/tools/llvm-mca/SummaryView.h Thu Apr 12 03:49:40 2018
@@ -45,7 +45,7 @@ public:
SummaryView(const SourceMgr &S, unsigned Width)
: Source(S), DispatchWidth(Width), TotalCycles(0) {}
- void onCycleEnd(unsigned /* unused */) override { ++TotalCycles; }
+ void onCycleEnd() override { ++TotalCycles; }
void printView(llvm::raw_ostream &OS) const override;
};
Modified: llvm/trunk/tools/llvm-mca/TimelineView.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/TimelineView.h?rev=329895&r1=329894&r2=329895&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-mca/TimelineView.h (original)
+++ llvm/trunk/tools/llvm-mca/TimelineView.h Thu Apr 12 03:49:40 2018
@@ -162,7 +162,7 @@ public:
}
// Event handlers.
- void onCycleBegin(unsigned Cycle) override { CurrentCycle = Cycle; }
+ void onCycleEnd() override { ++CurrentCycle; }
void onInstructionEvent(const HWInstructionEvent &Event) override;
// print functionalities.
More information about the llvm-commits
mailing list