[PATCH] D45641: Rename sys::Process::GetArgumentVector -> sys::windows::GetCommandLineArguments

[Rui Ueyama via Phabricator via llvm-commits]

ruiu created this revision.
ruiu added a reviewer: stella.stamenova.
Herald added a subscriber: hiraditya.

GetArgumentVector (or GetCommandLineArguments) is very Windows-specific.
I think it doesn't make much sense to provide that function from sys::Process.

I also made a change so that the function takes a BumpPtrAllocator
instead of SpecificBumpPtrAllocator. The latter is the class to call
dtors, but since char * is trivially destructible, we should use the
former class.


https://reviews.llvm.org/D45641

Files:
  llvm/include/llvm/Support/InitLLVM.h
  llvm/include/llvm/Support/Process.h
  llvm/lib/Support/InitLLVM.cpp
  llvm/lib/Support/Unix/Process.inc
  llvm/lib/Support/Windows/Process.inc
  llvm/lib/Support/Windows/WindowsSupport.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45641.142473.patch
Type: text/x-patch
Size: 8752 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180413/01a9890f/attachment.bin>