[PATCH] D45109: Remove -cc1 option "-backend-option"

[George Karpenkov via llvm-commits]

Thanks for the reply!

It makes sense but should have been done in a separate commit.

George

> On Apr 12, 2018, at 4:00 PM, Friedman, Eli <efriedma at codeaurora.org> wrote:
> 
> The test wasn't checking anything useful; the clang driver never passes "-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 <https://reviews.llvm.org/rL241565> .
> 
> -Eli
> 
> On 4/12/2018 3:55 PM, George Karpenkov wrote:
>> Hi Eli,
>> 
>> The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-kext-mkernel.c <https://github.com/llvm-mirror/clang/#diff-9312a36a58d8d3f2f91ef6567dff7563>` file:
>> instead of changing the run lines to use -mllvm you have removed them.
>> Was there a reason for the removal?
>> 
>> Regards,
>> George
>> 
>>> On Apr 12, 2018, at 3:25 PM, Eli Friedman via Phabricator via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>>> 
>>> This revision was automatically updated to reflect the committed changes.
>>> Closed by commit rL329965: Remove -cc1 option "-backend-option". (authored by efriedma, committed by ).
>>> Herald added a subscriber: llvm-commits.
>>> 
>>> Changed prior to commit:
>>>  https://reviews.llvm.org/D45109?vs=140484&id=142277#toc <https://reviews.llvm.org/D45109?vs=140484&id=142277#toc>
>>> 
>>> Repository:
>>>  rL LLVM
>>> 
>>> https://reviews.llvm.org/D45109 <https://reviews.llvm.org/D45109>
>>> 
>>> Files:
>>>  cfe/trunk/include/clang/Driver/CC1Options.td
>>>  cfe/trunk/include/clang/Frontend/CodeGenOptions.h
>>>  cfe/trunk/lib/CodeGen/BackendUtil.cpp
>>>  cfe/trunk/lib/Driver/ToolChains/Clang.cpp
>>>  cfe/trunk/lib/Frontend/CompilerInvocation.cpp
>>>  cfe/trunk/test/CodeGen/thinlto-backend-option.ll
>>>  cfe/trunk/test/CodeGenCUDA/link-device-bitcode.cu
>>>  cfe/trunk/test/Driver/aarch64-fix-cortex-a53-835769.c
>>>  cfe/trunk/test/Driver/apple-kext-mkernel.c
>>>  cfe/trunk/test/Driver/arm-restrict-it.c
>>>  cfe/trunk/test/Driver/debug-options.c
>>>  cfe/trunk/test/Driver/mglobal-merge.c
>>>  cfe/trunk/test/Driver/woa-restrict-it.c
>>>  cfe/trunk/test/Frontend/backend-option.c
>>> 
>>> <D45109.142277.patch>_______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
>> 
> 
> -- 
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180412/98868b6d/attachment.html>