<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks for the reply!<div class=""><br class=""></div><div class="">It makes sense but should have been done in a separate commit.</div><div class=""><br class=""></div><div class="">George<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 12, 2018, at 4:00 PM, Friedman, Eli <<a href="mailto:efriedma@codeaurora.org" class="">efriedma@codeaurora.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
<div text="#000000" bgcolor="#FFFFFF" class="">
<div class="moz-cite-prefix">The test wasn't checking anything
useful; the clang driver never passes "-arm-long-calls" to clang
-cc1. See <a class="moz-txt-link-freetext" href="https://reviews.llvm.org/rL241565">https://reviews.llvm.org/rL241565</a> .<br class="">
<br class="">
-Eli<br class="">
<br class="">
On 4/12/2018 3:55 PM, George Karpenkov wrote:<br class="">
</div>
<blockquote type="cite" cite="mid:5840E8C1-F68E-4701-BB47-4643CFD81E52@apple.com" class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
Hi Eli,
<div class=""><br class="">
</div>
<div class="">The commit makes sense, but I’m not sure about your
change to the `<a href="https://github.com/llvm-mirror/clang/#diff-9312a36a58d8d3f2f91ef6567dff7563" class="link-gray-dark" title="test/Driver/apple-kext-mkernel.c" style="box-sizing:
border-box; text-decoration: none; caret-color: rgb(36, 41,
46); font-family: SFMono-Regular, Consolas, "Liberation
Mono", Menlo, Courier, monospace; color: rgb(36, 41, 46)
!important;" moz-do-not-send="true">test/Driver/apple-kext-mkernel.c</a>`
file:</div>
<div class="">instead of changing the run lines to use -mllvm you
have removed them.</div>
<div class="">Was there a reason for the removal?</div>
<div class=""><br class="">
</div>
<div class="">Regards,</div>
<div class="">George</div>
<div class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On Apr 12, 2018, at 3:25 PM, Eli Friedman via
Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="" moz-do-not-send="true">llvm-commits@lists.llvm.org</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">This revision was automatically updated to
reflect the committed changes.<br class="">
Closed by commit rL329965: Remove -cc1 option
"-backend-option". (authored by
efriedma, committed by ).<br class="">
Herald added a subscriber: llvm-commits.<br class="">
<br class="">
Changed prior to commit:<br class="">
<a href="https://reviews.llvm.org/D45109?vs=140484&id=142277#toc" class="" moz-do-not-send="true">https://reviews.llvm.org/D45109?vs=140484&id=142277#toc</a><br class="">
<br class="">
Repository:<br class="">
rL LLVM<br class="">
<br class="">
<a href="https://reviews.llvm.org/D45109" class="" moz-do-not-send="true">https://reviews.llvm.org/D45109</a><br class="">
<br class="">
Files:<br class="">
cfe/trunk/include/clang/Driver/CC1Options.td<br class="">
cfe/trunk/include/clang/Frontend/CodeGenOptions.h<br class="">
cfe/trunk/lib/CodeGen/BackendUtil.cpp<br class="">
cfe/trunk/lib/Driver/ToolChains/Clang.cpp<br class="">
cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br class="">
cfe/trunk/test/CodeGen/thinlto-backend-option.ll<br class="">
cfe/trunk/test/CodeGenCUDA/link-device-bitcode.cu<br class="">
cfe/trunk/test/Driver/aarch64-fix-cortex-a53-835769.c<br class="">
cfe/trunk/test/Driver/apple-kext-mkernel.c<br class="">
cfe/trunk/test/Driver/arm-restrict-it.c<br class="">
cfe/trunk/test/Driver/debug-options.c<br class="">
cfe/trunk/test/Driver/mglobal-merge.c<br class="">
cfe/trunk/test/Driver/woa-restrict-it.c<br class="">
cfe/trunk/test/Frontend/backend-option.c<br class="">
<br class="">
<span id="cid:04DA59C2-2D35-4A8E-AAE4-7DA5E1171FBF" class=""><D45109.142277.patch></span>_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br class="">
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote><p class=""><br class="">
</p>
<pre class="moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
</div>
</div></blockquote></div><br class=""></div></body></html>