[PATCH] D45574: Add PPC64_GLINK dynamic tag

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

LGTM other than adding a gap between MIPS tags and PPC tags



================
Comment at: include/llvm/BinaryFormat/DynamicTags.def:178
                                                 // map, used for debugging.
+PPC64_DYNAMIC_TAG(PPC64_GLINK, 0x70000000) // Address of 32 bytes before the
+                                           // first glink lazy resolver stub.
----------------
I would add a newline and a `// PPC specific dynamic table entries` comment


================
Comment at: include/llvm/BinaryFormat/DynamicTags.def:191
 #undef MIPS_DYNAMIC_TAG
+#undef MIPS_DYNAMIC_TAG_DEFINED
 #endif
----------------
Good catch, I forgot to add those in my initial change.


Repository:
  rL LLVM

https://reviews.llvm.org/D45574