[PATCH] D45574: Add PPC64_GLINK dynamic tag

[Sean Fertile via Phabricator via llvm-commits]

sfertile created this revision.
sfertile added reviewers: hfinkel, echristo, syzaara, arichardson.
Herald added subscribers: kbarton, nemanjai.

Adds support for the PPC64_GLINK dynamic tag which is used in the ElfV2 abi.


Repository:
  rL LLVM

https://reviews.llvm.org/D45574

Files:
  include/llvm/BinaryFormat/DynamicTags.def
  test/tools/llvm-readobj/Inputs/ppc64.exe
  test/tools/llvm-readobj/ppc64-glink.test
  tools/llvm-readobj/ELFDumper.cpp


Index: tools/llvm-readobj/ELFDumper.cpp
===================================================================
--- tools/llvm-readobj/ELFDumper.cpp
+++ tools/llvm-readobj/ELFDumper.cpp
@@ -1551,20 +1551,31 @@
 #include "llvm/BinaryFormat/DynamicTags.def"
 #undef HEXAGON_DYNAMIC_TAG
     }
+
   case EM_MIPS:
     switch (Type) {
 #define MIPS_DYNAMIC_TAG(name, value)                                          \
   case DT_##name:                                                              \
     return #name;
 #include "llvm/BinaryFormat/DynamicTags.def"
 #undef MIPS_DYNAMIC_TAG
     }
+
+    case EM_PPC64:
+      switch(Type) {
+#define PPC64_DYNAMIC_TAG(name, value)                                         \
+    case DT_##name:                                                            \
+      return #name;
+#include "llvm/BinaryFormat/DynamicTags.def"
+#undef PPC64_DYNAMIC_TAG
+    }
   }
 #undef DYNAMIC_TAG
   switch (Type) {
 // Now handle all dynamic tags except the architecture specific ones
 #define MIPS_DYNAMIC_TAG(name, value)
 #define HEXAGON_DYNAMIC_TAG(name, value)
+#define PPC64_DYNAMIC_TAG(name, value)
 // Also ignore marker tags such as DT_HIOS (maps to DT_VERNEEDNUM), etc.
 #define DYNAMIC_TAG_MARKER(name, value)
 #define DYNAMIC_TAG(name, value)                                               \
@@ -1574,6 +1585,7 @@
 #undef DYNAMIC_TAG
 #undef MIPS_DYNAMIC_TAG
 #undef HEXAGON_DYNAMIC_TAG
+#undef PPC64_DYNAMIC_TAG
 #undef DYNAMIC_TAG_MARKER
   default: return "unknown";
   }
Index: test/tools/llvm-readobj/ppc64-glink.test
===================================================================
--- /dev/null
+++ test/tools/llvm-readobj/ppc64-glink.test
@@ -0,0 +1,11 @@
+# Check DT_PPC64_GLINK dynamic tag.
+
+RUN: llvm-readobj -dynamic-table %p/Inputs/ppc64.exe | FileCheck %s
+
+CHECK: Format: ELF64-ppc64
+CHECK: Arch: powerpc64le
+CHECK: AddressSize: 64bit
+
+CHECK:      DynamicSection [ (25 entries)
+CHECK-NEXT:   Tag                Type                 Name/Value
+CHECK:        0x0000000070000000 PPC64_GLINK          0x10000830
Index: include/llvm/BinaryFormat/DynamicTags.def
===================================================================
--- include/llvm/BinaryFormat/DynamicTags.def
+++ include/llvm/BinaryFormat/DynamicTags.def
@@ -16,6 +16,11 @@
 #define MIPS_DYNAMIC_TAG_DEFINED
 #endif
 
+#ifndef PPC64_DYNAMIC_TAG
+#define PPC64_DYNAMIC_TAG(name, value) DYNAMIC_TAG(name, value)
+#define PPC64_DYNAMIC_TAG_DEFINED
+#endif
+
 #ifndef DYNAMIC_TAG_MARKER
 #define DYNAMIC_TAG_MARKER(name, value) DYNAMIC_TAG(name, value)
 #define DYNAMIC_TAG_MARKER_DEFINED
@@ -170,6 +175,8 @@
                                                 // of a writable PLT.
 MIPS_DYNAMIC_TAG(MIPS_RLD_MAP_REL, 0x70000035)  // Relative offset of run time loader
                                                 // map, used for debugging.
+PPC64_DYNAMIC_TAG(PPC64_GLINK, 0x70000000) // Address of 32 bytes before the
+                                           // first glink lazy resolver stub.
 
 // Sun machine-independent extensions.
 DYNAMIC_TAG(AUXILIARY, 0x7FFFFFFD) // Shared object to load before self
@@ -181,7 +188,13 @@
 #endif
 #ifdef MIPS_DYNAMIC_TAG_DEFINED
 #undef MIPS_DYNAMIC_TAG
+#undef MIPS_DYNAMIC_TAG_DEFINED
 #endif
 #ifdef HEXAGON_DYNAMIC_TAG_DEFINED
 #undef HEXAGON_DYNAMIC_TAG
+#undef HEXAGON_DYNAMIC_TAG_DEFINED
+#endif
+#ifdef PPC64_DYNAMIC_TAG_DEFINED
+#undef PPC64_DYNAMIC_TAG
+#undef PPC64_DYNAMIC_TAG_DEFINED
 #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45574.142180.patch
Type: text/x-patch
Size: 3475 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180412/f120b145/attachment.bin>