[PATCH] D45585: [DAGCombiner][X86] When promoting loads don't use ZEXTLOAD even its legal
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 12 12:40:14 PDT 2018
craig.topper added inline comments.
================
Comment at: test/CodeGen/X86/pr32420.ll:16
+; CHECK-NEXT: movl %eax, %edx
+; CHECK-NEXT: shll $12, %edx
+; CHECK-NEXT: sarw $12, %dx
----------------
There's some oddly repeated code in here. It looks like we managed to duplicate the load.
================
Comment at: test/CodeGen/X86/pr34137.ll:14
; CHECK-NEXT: andl %eax, %ecx
+; CHECK-NEXT: andl %eax, %ecx
+; CHECK-NEXT: movzwl %cx, %ecx
----------------
Somethig odd happened here. There are 2 identical ands.
https://reviews.llvm.org/D45585
More information about the llvm-commits
mailing list