[PATCH] D45546: [CachePruning] Clarify the per-directory entry limit on Linux ext4.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: include/llvm/Support/CachePruning.h:56
   /// diminishing returns on the effectiveness of the cache, and file
   /// systems have a limit on total number of files.
+  /// Notably ext4 on Linux, with the default setting (block
----------------
pcc wrote:
> Update this bit.
Change to what?




================
Comment at: include/llvm/Support/CachePruning.h:57
   /// systems have a limit on total number of files.
+  /// Notably ext4 on Linux, with the default setting (block
+  /// size is 4096 and large_dir is off), there is a per-directory entry limit
----------------
pcc wrote:
> My first instinct is not to add this much detail, but I guess it might dissuade the next person who comes along to try to "correct" this comment.
Yeah I did not want to write the comment but you asked me to do so..


Repository:
  rL LLVM

https://reviews.llvm.org/D45546