[PATCH] D45546: [CachePruning] Clarify the per-directory entry limit on Linux ext4.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 11 17:33:24 PDT 2018
pcc added inline comments.
================
Comment at: include/llvm/Support/CachePruning.h:56
/// diminishing returns on the effectiveness of the cache, and file
/// systems have a limit on total number of files.
+ /// Notably ext4 on Linux, with the default setting (block
----------------
Update this bit.
================
Comment at: include/llvm/Support/CachePruning.h:57
/// systems have a limit on total number of files.
+ /// Notably ext4 on Linux, with the default setting (block
+ /// size is 4096 and large_dir is off), there is a per-directory entry limit
----------------
My first instinct is not to add this much detail, but I guess it might dissuade the next person who comes along to try to "correct" this comment.
Repository:
rL LLVM
https://reviews.llvm.org/D45546
More information about the llvm-commits
mailing list