[PATCH] D40556: SIFixSGPRCopies should not change non-divergent PHI

[Samuel Pitoiset via Phabricator via llvm-commits]

hakzsam added a comment.

In https://reviews.llvm.org/D40556#1061436, @alex-t wrote:

> It seems like this patch should be reverted. Recently we have no reliable
>  way to determine the PHI (or whatever else) divergence on the MI level.
>  The only correct way is to add the DA algorithm that re-computes all the MI
>  divergence.
>  Since we're going to remove the SGPRFix stuff as soon as diverence driven
>  ISel is ready I consider this patch is not necessary.


Thanks for looking into this. The main issue I see with a revert is that we will need a backport to LLVM 6.

Though, if it's the only solution for now, this sounds good to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D40556