[PATCH] D40556: SIFixSGPRCopies should not change non-divergent PHI

Alexander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 04:37:19 PDT 2018


alex-t added a comment.

It seems like this patch should be reverted. Recently we have no reliable
way to determine the PHI (or whatever else) divergence on the MI level.
The only correct way is to add the DA algorithm that re-computes all the MI
divergence.
Since we're going to remove the SGPRFix stuff as soon as diverence driven
ISel is ready I consider this patch is not necessary.


Repository:
  rL LLVM

https://reviews.llvm.org/D40556





More information about the llvm-commits mailing list