[PATCH] D45263: [SLP] Allow reordering of vectorization trees with reused instructions.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 9 06:52:49 PDT 2018


ABataev added a comment.

In https://reviews.llvm.org/D45263#1060684, @RKSimon wrote:

> Would it be possible to increase test coverage?


Yes, I will try to add some more tests.



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:5785
+               "Order size must be the same as number of vectorized "
+               "instructions.");
         // TODO: reorder tree nodes without tree rebuilding.
----------------
RKSimon wrote:
> This assert doesn't seem to tally with the TODO just above?
Actually, it does, I just need to remove this TODO. This patch fixes this TODO.


Repository:
  rL LLVM

https://reviews.llvm.org/D45263





More information about the llvm-commits mailing list