[PATCH] D45380: [X86] Add SchedWrites for CMOV and SETCC. Use them to remove InstRWs.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 8 02:41:05 PDT 2018
RKSimon accepted this revision.
RKSimon added a reviewer: GGanesh.
RKSimon added a subscriber: GGanesh.
RKSimon added a comment.
This revision is now accepted and ready to land.
Thanks - LGTM as an NFC - I guess the ryzen fixme can stay for now if @GGanesh doesn't get back in time.
================
Comment at: lib/Target/X86/X86ScheduleZnver1.td:620
+// FIXME why doesn't this need an AGU?
def : InstRW<[WriteShift],
(instregex "SET(O|NO|B|AE|E|NE|BE|A|S|NS|P|NP|L|GE|LE|G)m")>;
----------------
@craig.topper You can probably fold this into the WriteSETCC declarations above and move the FIXME question there.
@GGanesh shouldn't this have a ZnAGU dependency?
Repository:
rL LLVM
https://reviews.llvm.org/D45380
More information about the llvm-commits
mailing list