[PATCH] D45259: [MC][Tablegen] Allow models to describe the retire control unit for llvm-mca.

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: tools/llvm-mca/Dispatch.cpp:262
+      AvailableSlots = EPI.ReorderBufferSize;
+    if (!MaxRetirePerCycle)
+      MaxRetirePerCycle = EPI.MaxRetirePerCycle;
----------------
Can we get rid of the MaxRetirePerCycle ctor parameter ? Is there any reason why the user would override this ?


================
Comment at: tools/llvm-mca/Dispatch.h:194
 
+  void initialize(const llvm::MCSchedModel &SM);
+
----------------
Any reason for this to be in a separate function ? What about moving the ctor definition to the cpp file and inlining the code ?
Else when reading the ctor definition here it's not obvious that AvailableSlots might be overridden in initialize().


https://reviews.llvm.org/D45259