[PATCH] D45003: [Support] Make line-number cache robust against access patterns.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In https://reviews.llvm.org/D45003#1055099, @graydon wrote:

> In https://reviews.llvm.org/D45003#1053430, @probinson wrote:
>
> > There's commentary in lib/MC/MCParser/AsmParser.cpp about the ungraceful degradation in SourceMgr's cache.  Would this help or simplify what AsmParser is doing?
>
>
> I believe this should eliminate the behaviour those comments describe (and thus remove the need for the code), though I feel a bit under-qualified tinkering with the code there itself. Would you like me to try, or shall I leave it to the owners of that file?


If you could have a go at it, that would be great.  It's fine to do it as a follow-up NFC patch.  Or file a bug and cc me.  It's not really my area either but I keep running across that comment and it has always bothered me, maybe enough to do something now.


Repository:
  rL LLVM

https://reviews.llvm.org/D45003