[PATCH] D45003: [Support] Make line-number cache robust against access patterns.
Graydon Hoare via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 2 17:28:53 PDT 2018
graydon added a comment.
In https://reviews.llvm.org/D45003#1053430, @probinson wrote:
> There's commentary in lib/MC/MCParser/AsmParser.cpp about the ungraceful degradation in SourceMgr's cache. Would this help or simplify what AsmParser is doing?
I believe this should eliminate the behaviour those comments describe (and thus remove the need for the code), though I feel a bit under-qualified tinkering with the code there itself. Would you like me to try, or shall I leave it to the owners of that file?
Repository:
rL LLVM
https://reviews.llvm.org/D45003
More information about the llvm-commits
mailing list