[PATCH] D45122: [DebugInfo] Add a new DI flag to record if a C++ record is a trivial type

[David Blaikie via llvm-commits]

I'm still not sure this description/name matches the examples given in the
other review from Reid.

Sounds like this is more about whether it has a trivial default
constructor, specifically? (which, yes, is different from the triviality of
copy construction which is relevant to the DWARF flag we already have) -
some test cases/demonstrations of the MSVC behavior might be helpful?

On Tue, Apr 3, 2018 at 10:43 AM Aaron Smith via Phabricator <
reviews at reviews.llvm.org> wrote:

> asmith added a comment.
>
> The meaning of trivial is the same. There are some differences with MSVC
> in the generated CodeView that are documented in the FIXMEs in
> https://reviews.llvm.org/D45123.
>
> LLDB is going to use this to construct a CXXRecordDecl when parsing record
> symbols (PDBSymbolTypeUdt and PDBSymbolBaseclass). FunctionOptions,
> ClassOptions and MethodOptions rely on this information which is currently
> missing in LLVMs CV.
>
> See https://reviews.llvm.org/D44406 for what kicked all this off
> originally.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D45122
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180403/261f3013/attachment.html>