[PATCH] D45043: [DebugInfo] Add test cases for generating debug info of labels.

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: test/DebugInfo/debuglabel.ll:6
+; CHECK-NEXT: DW_AT_name [DW_FORM_strp]
+; CHECK-SAME: top
+; CHECK-NEXT: DW_AT_decl_file [DW_FORM_data1]
----------------
Generally we don't use SAME unless the line is getting long; I know I would find it easier to read these as one line:
`CHECK-NEXT: DW_AT_name [DW_FORM_strp] {{.*}} "top"`


================
Comment at: test/DebugInfo/debuglabel.ll:25
+;
+; ASM: [[TOP_LOW_PC:[.0-9a-zA-Z]+]]:{{[[:space:]].*}}DEBUG_LABEL: foo:top
+; ASM: [[DONE_LOW_PC:[.0-9a-zA-Z]+]]:{{[[:space:]].*}}DEBUG_LABEL: foo:done
----------------
You could put a space before the regex and remove the `[[:space:]]` to make these more readable.


Repository:
  rL LLVM

https://reviews.llvm.org/D45043