[PATCH] D45043: [DebugInfo] Add test cases for generating debug info of labels.

[Wei-Ren Chen via Phabricator via llvm-commits]

chenwj requested changes to this revision.
chenwj added a comment.
This revision now requires changes to proceed.

I think the test case should be a general one, not relate to any particular target.



================
Comment at: test/DebugInfo/debuglabel.ll:1
+; RUN: llc -O0 -filetype=obj -o - %s | llvm-dwarfdump -v - | FileCheck %s
+;
----------------
`test/DebugInfo/Generic/` would be a better place for this test case.


================
Comment at: test/DebugInfo/debuglabel.ll:43
+source_filename = "debuglabel.c"
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
----------------
Better check other test cases, I don't think this generic case should have target-dependent parts.


Repository:
  rL LLVM

https://reviews.llvm.org/D45043