[PATCH] D41330: [X86] Reduce Store Forward Block issues in HW

[Lama via Phabricator via llvm-commits]

lsaba added inline comments.


================
Comment at: lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp:347
+  const unsigned InspectionLimit = X86AvoidSFBInspectionLimit;
+  for (auto PBInst = std::next(MachineBasicBlock::reverse_iterator(LoadInst)),
+            E = LoadInst->getParent()->rend();
----------------
craig.topper wrote:
> I don't think you want std::next here. reverse_iterator already makes it point to the instruction before LoadInst. So now I think you skip that instruction.
are you sure? I've double checked, without std::next the iterator starts from the load instruction 


https://reviews.llvm.org/D41330