[PATCH] D41330: [X86] Reduce Store Forward Block issues in HW
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 29 10:39:03 PDT 2018
craig.topper added inline comments.
================
Comment at: lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp:347
+ const unsigned InspectionLimit = X86AvoidSFBInspectionLimit;
+ for (auto PBInst = std::next(MachineBasicBlock::reverse_iterator(LoadInst)),
+ E = LoadInst->getParent()->rend();
----------------
I don't think you want std::next here. reverse_iterator already makes it point to the instruction before LoadInst. So now I think you skip that instruction.
https://reviews.llvm.org/D41330
More information about the llvm-commits
mailing list