[PATCH] D36351: [lld][ELF] Add profile guided section layout

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 28 23:06:56 PDT 2018


espindola added inline comments.


================
Comment at: ELF/CallGraphSort.cpp:149
+
+bool Edge::operator==(const Edge Other) const {
+  return From == Other.From && To == Other.To;
----------------
const Edge &Other


================
Comment at: ELF/Config.h:27
 class InputFile;
+class InputSectionBase;
+class Symbol;
----------------
dead declaration.


================
Comment at: ELF/Driver.cpp:600
+    if (FromSym && ToSym)
+      Config->CallGraphProfile[std::make_pair(FromSym, ToSym)] += Count;
+  }
----------------
This should now be just =, no?


https://reviews.llvm.org/D36351





More information about the llvm-commits mailing list