[PATCH] D36351: [lld][ELF] Add profile guided section layout

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 28 22:48:32 PDT 2018


espindola added inline comments.


================
Comment at: ELF/CallGraphSort.cpp:56
+namespace {
+using ClusterIndex = std::ptrdiff_t;
+using SectionIndex = std::ptrdiff_t;
----------------
dead code.


================
Comment at: ELF/CallGraphSort.cpp:57
+using ClusterIndex = std::ptrdiff_t;
+using SectionIndex = std::ptrdiff_t;
+using EdgeIndex = std::ptrdiff_t;
----------------
Why do you need a 64 bit index. Why does it need a typedef?


https://reviews.llvm.org/D36351





More information about the llvm-commits mailing list