[PATCH] D44687: [SchedModel] Remove instregex entries that don't match any instructions (WIP)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 08:56:37 PDT 2018


RKSimon added a comment.

In https://reviews.llvm.org/D44687#1044503, @javed.absar wrote:

> Thanks for this. If I am getting this right, just like CompleteModel ensures no instruction has a missing schedule, this patch will ensure no instruction has multiple schedule (instregex) assigned?


Not quite (thats another check that I'll be adding soon....) - this patch just errors out if the instregex is not used at all - from the cases I've seen its usually a mixture of copy+paste (not all instructions have all the same variations) and typos in the regex pattern.


Repository:
  rL LLVM

https://reviews.llvm.org/D44687





More information about the llvm-commits mailing list