[PATCH] D44713: Unsubmitted part of D44599

[David CARLIER via Phabricator via llvm-commits]

devnexen added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:72
 #include <sys/futex.h>
+extern char **environ;
 #endif
----------------
vitalybuka wrote:
> this should not be needed after r328077
I commented this commit [[ https://reviews.llvm.org/rL327904 |here]]


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:341
 #elif SANITIZER_USES_CANONICAL_LINUX_SYSCALLS
   return internal_syscall(SYSCALL(newfstatat), AT_FDCWD, (uptr)path, (uptr)buf,
                           AT_SYMLINK_NOFOLLOW);
----------------
vitalybuka wrote:
> What about this?
I thought I did this one ...


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:1754
+#if SANITIZER_OPENBSD
+  *pc = 0;
+  *bp = 0;
----------------
vitalybuka wrote:
> Why zeroes? Can you get real values?
ucontext not supported here.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44713