[PATCH] D44713: Unsubmitted part of D44599
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 21 00:53:06 PDT 2018
vitalybuka added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:72
#include <sys/futex.h>
+extern char **environ;
#endif
----------------
this should not be needed after r328077
================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:341
#elif SANITIZER_USES_CANONICAL_LINUX_SYSCALLS
return internal_syscall(SYSCALL(newfstatat), AT_FDCWD, (uptr)path, (uptr)buf,
AT_SYMLINK_NOFOLLOW);
----------------
What about this?
================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:1754
+#if SANITIZER_OPENBSD
+ *pc = 0;
+ *bp = 0;
----------------
Why zeroes? Can you get real values?
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D44713
More information about the llvm-commits
mailing list