[PATCH] D44570: [dwarf] Unify unknown dwarf enum formatting code

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 06:34:16 PDT 2018


labath updated this revision to Diff 139115.
labath added a comment.

- changed "Unknown" to "unknown". I have checked GNU readelf output, they format unknown values completely differently (Unknown TAG value: 0x3e), so this doesn't make the compatibility story worse.
- added FORM, IDX, and AT format providers. These are the ones that are in use currently. Adding the rest is straight-forward.
- I did *not* add the ATOM format provider. To achieve this, we first need to create a separate enum for the DW_ATOM constants, so I left that for a follow-up patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D44570

Files:
  include/llvm/BinaryFormat/Dwarf.h
  lib/BinaryFormat/Dwarf.cpp
  lib/DebugInfo/DWARF/DWARFAbbreviationDeclaration.cpp
  lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp
  lib/DebugInfo/DWARF/DWARFDie.cpp
  unittests/BinaryFormat/DwarfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44570.139115.patch
Type: text/x-patch
Size: 10535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180320/fad2c71c/attachment.bin>


More information about the llvm-commits mailing list