[PATCH] D44266: [InstCombine] remove use restriction for min/max with not operands (PR35875)

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 18 14:41:38 PDT 2018


dmgreen added a comment.

Sorry for the delay. I obviously like this because it fixes my regression :)

Before I went away I ran a load of benchmarks. They eventually finished and showed no regressions except for this rgb to cmy case (which went up 48% on v6m targets!)

If this is unpalatable because it can increase instruction count, we may be able to do something in IsFreeOrProfitableToInvert in InstCombineSelect. Is checking the users in InstCombine (more than just counting them) not a done thing?


https://reviews.llvm.org/D44266





More information about the llvm-commits mailing list