[PATCH] D44424: [InstCombine] peek through unsigned FP casts for zero-equality compares (PR36682)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Thank you for the review!



================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:4516
+      return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
+  }
+
----------------
spatel wrote:
> Don't need braces for the single-line 'if' clause.
It occupies more than one line though.
But ok, if you insist.


================
Comment at: test/Transforms/InstCombine/cast-unsigned-icmp-eqcmp-0.ll:4
 
 ; target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 
----------------
spatel wrote:
> Remove unnecessary comment line.
For future reference, could you please clarify *when* `target datalayout` //should// be specified in tests?


Repository:
  rL LLVM

https://reviews.llvm.org/D44424