[PATCH] D44424: [InstCombine] peek through unsigned FP casts for zero-equality compares (PR36682)
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 18 07:41:44 PDT 2018
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM. See inline for a couple of nits.
================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:4516
+ return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
+ }
+
----------------
Don't need braces for the single-line 'if' clause.
================
Comment at: test/Transforms/InstCombine/cast-unsigned-icmp-eqcmp-0.ll:4
; target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
Remove unnecessary comment line.
Repository:
rL LLVM
https://reviews.llvm.org/D44424
More information about the llvm-commits
mailing list