[PATCH] D44370: [X86] Combine vXi64 multiplies to MULDQ/MULUDQ during DAG combine instead of lowering.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 16 08:44:42 PDT 2018


RKSimon added a comment.

So what do you think we should do about this regression? We /could/ fix it via getFauxShuffleMask but there are probably better ways.



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:33117
+  if (DAG.MaskedValueIsZero(N0, Mask) && DAG.MaskedValueIsZero(N1, Mask)) {
+    auto PMULDQBuilder = [](SelectionDAG &DAG, const SDLoc &DL,
+                            ArrayRef<SDValue> Ops) {
----------------
PMULUDQBuilder ?


Repository:
  rL LLVM

https://reviews.llvm.org/D44370





More information about the llvm-commits mailing list