[PATCH] D44504: COFF: Implement string tail merging.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

This feature is awesome. I strongly believe that Microsoft should do the same thing in the next version of MSVC. :)



================
Comment at: lld/COFF/ICF.cpp:230
+  for (auto &P : MergeChunk::Instances)
+    for (auto *SC : P.second->Sections)
+      SC->Class[0] = NextId++;
----------------
pcc wrote:
> ruiu wrote:
> > auto -> MergeSection
> It would actually be `std::pair<const uint32_t, MergeChunk *>`, which seems a little verbose, so I left it the way it is.
But what about SC? Isn't it SectionChunk?


https://reviews.llvm.org/D44504