[PATCH] D44504: COFF: Implement string tail merging.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 15 12:48:38 PDT 2018
pcc added inline comments.
================
Comment at: lld/COFF/ICF.cpp:230
+ for (auto &P : MergeChunk::Instances)
+ for (auto *SC : P.second->Sections)
+ SC->Class[0] = NextId++;
----------------
ruiu wrote:
> auto -> MergeSection
It would actually be `std::pair<const uint32_t, MergeChunk *>`, which seems a little verbose, so I left it the way it is.
================
Comment at: lld/COFF/Writer.cpp:429
+ for (auto &P : MergeChunk::Instances)
+ RData->addChunk(P.second);
----------------
ruiu wrote:
> auto -> MergeSection
Likewise
https://reviews.llvm.org/D44504
More information about the llvm-commits
mailing list