[PATCH] D42728: Add more warnings for implict conversions (e.g. double truncation to float).

[Andrew V. Tischenko via Phabricator via llvm-commits]

avt77 added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:9200
+  // Recurse on the LHS and RHS in here
+  AnalyzeAssignment(S, E);
+
----------------
rjmccall wrote:
> It's not obvious that the bit-field special case in that function is appropriate for all compound assignments.  For now, let's just leave that function for simple assignments; we can directly call AnalyzeImplicitConversions on the LHS and RHS here.
There is one problem only here: if we don't support the bit-field special case here then we have several additional tests failed. But OK - I'll do it.


https://reviews.llvm.org/D42728