[PATCH] D42728: Add more warnings for implict conversions (e.g. double truncation to float).

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 13:02:57 PDT 2018


rjmccall added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:9200
+  // Recurse on the LHS and RHS in here
+  AnalyzeAssignment(S, E);
+
----------------
It's not obvious that the bit-field special case in that function is appropriate for all compound assignments.  For now, let's just leave that function for simple assignments; we can directly call AnalyzeImplicitConversions on the LHS and RHS here.


https://reviews.llvm.org/D42728





More information about the llvm-commits mailing list