[PATCH] D44367: [InstCombine] peek through FP casts for sign-bit compares (PR36682)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D44367#1035664, @lebedev.ri wrote:

> In https://reviews.llvm.org/D44367#1035291, @spatel wrote:
>
> > In https://reviews.llvm.org/D44367#1035281, @lebedev.ri wrote:
> >
> > > Those don't really match the differential's subject, i'd say they should be in the next one[s].
> > >  (I suppose i can implement those cases now that there is an example :))
> >
> >
> > No need - I already have the patch done. I just wasn't sure whether 1 step or multiple would be preferred.
>
>
>
>
> > I haven't worked on the uitofp InstSimplify patch if you want to handle that one.
>
> Ok, sounds good, i'll look into that then.


And done, https://reviews.llvm.org/D44416 / https://reviews.llvm.org/D44421 / https://reviews.llvm.org/D44424 / https://reviews.llvm.org/D44425.
Only two patterns in each, others are either canonicalized to them, or are invalid as per alive.


https://reviews.llvm.org/D44367