[PATCH] D44367: [InstCombine] peek through FP casts for sign-bit compares (PR36682)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 13 03:50:55 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D44367#1035291, @spatel wrote:

> In https://reviews.llvm.org/D44367#1035281, @lebedev.ri wrote:
>
> > Those don't really match the differential's subject, i'd say they should be in the next one[s].
> >  (I suppose i can implement those cases now that there is an example :))
>
>
> No need - I already have the patch done. I just wasn't sure whether 1 step or multiple would be preferred.




> I haven't worked on the uitofp InstSimplify patch if you want to handle that one.

Ok, sounds good, i'll look into that then.


https://reviews.llvm.org/D44367





More information about the llvm-commits mailing list