[PATCH] D43286: [CodeGen] Generate DWARF v5 Accelerator Tables

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 9 13:40:26 PST 2018


aprantl added a comment.

> After my adventures on the parsing side (and reading the DWARF 5 form classes section), I've concluded that emitting the DIE offset as a DW_FORM_section_offset is not the right thing to do. The most correct class here seems to be the "reference" class (DW_FORM_refX), so I've changed it to that, although a case could be made for the DW_FORM_dataX forms (which are used by the apple tables) as well. I wish the dwarf standard could be more specific here.

If you want to, we could bring this up on the dwarf-discuss mailing list. It will be pretty much the same people as here, but the outcome will have more of a binding character :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D43286





More information about the llvm-commits mailing list