[PATCH] D43286: [CodeGen] Generate DWARF v5 Accelerator Tables

[Pavel Labath via Phabricator via llvm-commits]

labath updated this revision to Diff 137732.
labath marked 14 inline comments as done.
labath added a comment.

- use DIEInteger functions to avoid computing form sizes manually
- add llvm-dwarfdump -verify lines to check the generated output in tests
- After my adventures on the parsing side (and reading the DWARF 5 form classes section), I've concluded that emitting the DIE offset as a DW_FORM_section_offset is not the right thing to do. The most correct class here seems to be the "reference" class (DW_FORM_refX), so I've changed it to that, although a case could be made for the DW_FORM_dataX forms (which are used by the apple tables) as well. I wish the dwarf standard could be more specific here.


Repository:
  rL LLVM

https://reviews.llvm.org/D43286

Files:
  include/llvm/CodeGen/AccelTable.h
  include/llvm/MC/MCObjectFileInfo.h
  lib/CodeGen/AsmPrinter/AccelTable.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  lib/MC/MCObjectFileInfo.cpp
  test/DebugInfo/Generic/accel-table-hash-collisions.ll
  test/DebugInfo/Generic/cross-cu-inlining.ll
  test/DebugInfo/Generic/debug-names-hash-collisions.ll
  test/DebugInfo/Generic/debug-names-many-cu.ll
  test/DebugInfo/Generic/debug-names-name-collisions.ll
  test/DebugInfo/Generic/debug-names-one-cu.ll
  test/DebugInfo/Generic/debug-names-two-cu.ll
  test/DebugInfo/X86/coff_debug_info_type.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43286.137732.patch
Type: text/x-patch
Size: 175463 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180309/a00ad704/attachment-0001.bin>