[PATCH] D44168: [ELF] Add .eh_frame pieces to map file

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

Apart from the typo and the value for the alignment, LGTM.



================
Comment at: lld/ELF/MapFile.cpp:122
+  auto Add = [&](const EhSectionPiece &P) {
+    // If P is adjuscent to Last, squash the two.
+    if (!Pieces.empty()) {
----------------
Typo: adjuscent -> adjacent.


================
Comment at: lld/ELF/MapFile.cpp:143
+  for (EhSectionPiece &P : Pieces) {
+    writeHeader(OS, OSec->Addr + P.OutputOff, P.Size, 0);
+    OS << indent(1) << toString(P.Sec->File) << ":(" << P.Sec->Name << "+0x"
----------------
Perhaps instead of 0 for the alignment, this could be the EhSectionPiece alignment which is Config->Wordsize?


https://reviews.llvm.org/D44168