[PATCH] D44283: Don't treat .symver as a regular alias definition
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 8 17:50:43 PST 2018
vitalybuka added inline comments.
================
Comment at: lib/MC/MCParser/ELFAsmParser.cpp:774
MCSymbol *Sym = getContext().getOrCreateSymbol(Name);
- const MCExpr *Value = MCSymbolRefExpr::create(Sym, getContext());
-
- getStreamer().EmitAssignment(Alias, Value);
getStreamer().emitELFSymverDirective(Alias, Sym);
return false;
----------------
pcc wrote:
> vitalybuka wrote:
> > Can we still pass AliasName instead of created Alias ?
> >
> >
> Most clients will want to consume the MCSymbol, so it seems a little simpler to create it here.
Then I am sure when to replace @@@ with @ or @@
https://reviews.llvm.org/D44283
More information about the llvm-commits
mailing list