[PATCH] D44283: Don't treat .symver as a regular alias definition
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 8 17:47:56 PST 2018
pcc accepted this revision.
pcc added a comment.
LGTM
================
Comment at: lib/MC/MCParser/ELFAsmParser.cpp:774
MCSymbol *Sym = getContext().getOrCreateSymbol(Name);
- const MCExpr *Value = MCSymbolRefExpr::create(Sym, getContext());
-
- getStreamer().EmitAssignment(Alias, Value);
getStreamer().emitELFSymverDirective(Alias, Sym);
return false;
----------------
vitalybuka wrote:
> Can we still pass AliasName instead of created Alias ?
>
>
Most clients will want to consume the MCSymbol, so it seems a little simpler to create it here.
https://reviews.llvm.org/D44283
More information about the llvm-commits
mailing list