[PATCH] D44150: [WebAssembly] Move WasmSignatureDenseMapInfo to header for reuse. NFC

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Having two copies seems fine for now.



================
Comment at: wasm/WriterUtils.h:24
+// Needed for DenseMapInfo<wasm::WasmSignature>
 inline bool operator==(const llvm::wasm::WasmSignature &LHS,
                        const llvm::wasm::WasmSignature &RHS) {
----------------
Do these need to be moved into the namespace?  if so can you drop the extra llvm:: prefixes?


================
Comment at: wasm/WriterUtils.h:65
+                      const wasm::WasmSignature &RHS) {
+    return LHS == RHS;
+  }
----------------
Should we just inline this and drop the operators overloads for signatures?  Or are they used elsewhere?  (In which case the comment neeeds updating I guess).




Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44150