[PATCH] D44150: [WebAssembly] Move WasmSignatureDenseMapInfo to header for reuse. NFC
Nicholas Wilson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 6 14:52:57 PST 2018
ncw added a comment.
In https://reviews.llvm.org/D44150#1029149, @sbc100 wrote:
> I'm not sure about putting this stuff in the BinaryFormat. To me it makes sense to keep those headers as mostly structures and enums. If its just a matter of having this in two places I don't think that a huge deal (although the one in llvm is missing a recent fix which argues against my point :)
Bikeshed time! Feel free to suggest any header you like, I'm not picky... Would it be allowed to give Wasm another header like `BinaryFormat/Wasm{Util/Ops/MapTraits/...}.h`? The DenseMap traits are a bit specific and maybe could earn a header of their own, but personally I feel utilities like `operator==` should really go alongside their structs, since they're so useful to have around.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D44150
More information about the llvm-commits
mailing list