[PATCH] D43752: [RISCV] Preserve stack space for outgoing arguments when the function contain variable size objects

Shiva Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 4 23:07:20 PST 2018


shiva0217 updated this revision to Diff 136950.
shiva0217 added a comment.

Hi Alex. The patch has been updated. The codgen result in calling-conv.ll:caller_many_scalars function with FP has changed due to we override the hasReservedCallFrame function. According to the logic in determineFrameLayout, the SP adjustment will change from 32 to 16. It seems that we could also remove the logic in determineFrameLayout relative to variable size objects because eliminateCallFramePseudoInstr could handle it, right?


Repository:
  rL LLVM

https://reviews.llvm.org/D43752

Files:
  lib/Target/RISCV/RISCVFrameLowering.cpp
  lib/Target/RISCV/RISCVFrameLowering.h
  test/CodeGen/RISCV/alloca.ll
  test/CodeGen/RISCV/calling-conv.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43752.136950.patch
Type: text/x-patch
Size: 6424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180305/24d2ba6c/attachment.bin>


More information about the llvm-commits mailing list