[PATCH] D43752: [RISCV] Preserve stack space for outgoing arguments when the function contain variable size objects
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 2 02:55:03 PST 2018
asb added a comment.
In https://reviews.llvm.org/D43752#1024857, @shiva0217 wrote:
> Hi Alex. Default hasReservedCallFrame will return !hasFP(), so these cases will generate extra sp adjustment, we could override hasReservedCallFrame as !hasVarSizedObjects() to avoid this and thanks for update the test case which make it more clean and clear!
That sounds like the right thing to do, and would avoid the (minor) codegen regression. Could you update to make that change? Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D43752
More information about the llvm-commits
mailing list