[PATCH] D43879: Cleanup in sanitizer_common_interceptors.inc
Kamil Rytarowski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 3 05:15:00 PST 2018
krytarowski added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7270
-#if SANITIZER_NETBSD
- COMMON_INTERCEPT_FUNCTION(__libc_mutex_lock);
- COMMON_INTERCEPT_FUNCTION(__libc_mutex_unlock);
- COMMON_INTERCEPT_FUNCTION(__libc_thr_setcancelstate);
-#endif
+ COMMON_MAYBE_INTERCEPT_NETBSD_ALIAS(mutex_lock);
+ COMMON_MAYBE_INTERCEPT_NETBSD_ALIAS(mutex_unlock);
----------------
vitalybuka wrote:
> for consistency it should be
> INIT_MUTEX_LOCK
> INIT_MUTEX_UNLOCK
> INIT_SET_CANCEL_STATE
>
> All INIT_* macros are already MAYBE and enabled/disabled according to the platform.
These ones are aliases specific to NetBSD libc.
How about: `INIT_NETBSD_ALIAS*` and `INIT_NETBSD_ALIAS_THR*`?
Repository:
rL LLVM
https://reviews.llvm.org/D43879
More information about the llvm-commits
mailing list