[PATCH] D43879: Cleanup in sanitizer_common_interceptors.inc

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 11:57:42 PST 2018


vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7270
 
-#if SANITIZER_NETBSD
-  COMMON_INTERCEPT_FUNCTION(__libc_mutex_lock);
-  COMMON_INTERCEPT_FUNCTION(__libc_mutex_unlock);
-  COMMON_INTERCEPT_FUNCTION(__libc_thr_setcancelstate);
-#endif
+  COMMON_MAYBE_INTERCEPT_NETBSD_ALIAS(mutex_lock);
+  COMMON_MAYBE_INTERCEPT_NETBSD_ALIAS(mutex_unlock);
----------------
for consistency it should be 
INIT_MUTEX_LOCK
INIT_MUTEX_UNLOCK
INIT_SET_CANCEL_STATE

All INIT_* macros are already MAYBE and enabled/disabled according to the platform.


Repository:
  rL LLVM

https://reviews.llvm.org/D43879





More information about the llvm-commits mailing list